Skip to content

[Celestica] Leh800bcls: Fix AgentTrunkTest crash in multi-NPU environment by passing platform type in config generation - #1501

Open
gang-tao wants to merge 1 commit into
facebook:mainfrom
gang-tao:leh800bcls_agent_fix22
Open

[Celestica] Leh800bcls: Fix AgentTrunkTest crash in multi-NPU environment by passing platform type in config generation#1501
gang-tao wants to merge 1 commit into
facebook:mainfrom
gang-tao:leh800bcls_agent_fix22

Conversation

@gang-tao

@gang-tao gang-tao commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • [ ✓ ] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • [ ✓ ] pre-commit run
clang-format.............................................................Passed
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Prevent sai_impl in fboss manifest.......................................Passed

Summary

Fixes a crash in fboss_hw_agent during AgentTrunkTest cases in multi-NPU (Split Agent) environments. fboss_hw_agent0 crashed with 'counter_get() failed(Invalid unit)' during initialization.

Error: counter_get() failed(Invalid unit).
E0810 15:02:20.451190 1978187 SaiApiError.h:67] [switch] Failed to create sai entity SwitchSaiId(17947989248409862144): (InitSwitch: true, HwInfo: [], SrcMac: 66:f6:4d:d1:59:fd, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, MacAgingTime: 300, nullopt, nullopt, nullopt, nullopt
, UseEcnThresholds: true, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt
, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, PfcTcDldTimerGranularityInterval: [(mapping: key: 0, value: 10), (mapping: key: 1, value: 10), (mapping: key: 2, value: 10), (mapping: key: 3, value: 10), (mapping: key: 4, va
lue: 10), (mapping: key: 5, value: 10), (mapping: key: 6, value: 10), (mapping: key: 7, value: 10)], nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt, nullopt): FAILURE

Root Cause

In AgentTrunkTest::initialConfig(), the configuration was generated by calling utility::oneL3IntfTwoPortConfig() without passing the platformType. In multi-NPU environments, omitting the platform type causes the configuration generator to fall back to a single-NPU configuration.

Solution

In utility::oneL3IntfTwoPortConfig() to explicitly pass the platformType (retrieved via ensemble.getSw()->getPlatformType()).

Test Plan

Successfully ran and verified all Trunk tests on Leh800bcls platform (NPU0 and NPU1):

  • NPU0
Running all tests took 0:05:53.619048 between 2026-08-10 16:08:21.121951 and 2026-08-10 16:14:14.740999
[ PASSED ] cold_boot.AgentTrunkTest.TrunkCreateHighLowKeyIds (21927 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkCreateHighLowKeyIds (12099 ms)
[ PASSED ] cold_boot.AgentTrunkTest.TrunkCheckIngressPktAggPort (21715 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkCheckIngressPktAggPort (11247 ms)
[ PASSED ] cold_boot.AgentTrunkTest.TrunkMemberPortDownMinLinksViolated (21853 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkMemberPortDownMinLinksViolated (12202 ms)
[ PASSED ] cold_boot.AgentTrunkTest.TrunkPortStats (25375 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkPortStats (15034 ms)
[ PASSED ] cold_boot.AgentTrunkTest.TrunkCapacityUpdatesOnMemberDown (26950 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkCapacityUpdatesOnMemberDown (16058 ms)
Summary:
   PASSED : 10
   FAILED : 0
   SKIPPED : 0
   TIMEOUT : 0
  • NPU1
Running all tests took 0:05:50.088523 between 2026-08-10 16:16:37.923524 and 2026-08-10 16:22:28.012047
[ PASSED ] cold_boot.AgentTrunkTest.TrunkCreateHighLowKeyIds (20600 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkCreateHighLowKeyIds (10205 ms)
[ PASSED ] cold_boot.AgentTrunkTest.TrunkCheckIngressPktAggPort (21644 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkCheckIngressPktAggPort (11171 ms)
[ PASSED ] cold_boot.AgentTrunkTest.TrunkMemberPortDownMinLinksViolated (22897 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkMemberPortDownMinLinksViolated (12236 ms)
[ PASSED ] cold_boot.AgentTrunkTest.TrunkPortStats (25240 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkPortStats (16088 ms)
[ PASSED ] cold_boot.AgentTrunkTest.TrunkCapacityUpdatesOnMemberDown (26488 ms)
[ PASSED ] warm_boot.AgentTrunkTest.TrunkCapacityUpdatesOnMemberDown (15404 ms)
Summary:
   PASSED : 10
   FAILED : 0
   SKIPPED : 0
   TIMEOUT : 0

@gang-tao
[Celestica] Leh800bcls: Fix AgentTrunkTest crash in multi-NPU environ…
e15633e 
…ment by passing platform type in config generation
@gang-tao
gang-tao requested a review from a team as a code owner August 11, 2026 01:45
@meta-cla meta-cla Bot added the CLA Signed label Aug 11, 2026
@meta-codesync

meta-codesync Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@jchallag has imported this pull request. If you are a Meta employee, you can view this in D115625858.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

celestica CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gang-tao